-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove GetExporters
from component.Host
#9987
Remove GetExporters
from component.Host
#9987
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9987 +/- ##
==========================================
- Coverage 91.78% 91.67% -0.12%
==========================================
Files 359 360 +1
Lines 16631 16641 +10
==========================================
- Hits 15265 15255 -10
- Misses 1040 1053 +13
- Partials 326 333 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should
- Assert somewhere that the service implementation of
component.Host
still has this method. - File an issue on the service 1.0 milestone tracker to remove this from the service implementation
@mx-psi to avoid losing any context, I was planning to move #7370 from the component milestone to the service milestone once this is merged. I will add a not in that issue for what extra stuff needs done for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the same issue works for me :)
Description:
Remove the deprecated
GetExporters
function fromcomponent.Host
Link to tracking Issue:
Related to #7370