[service] Move TracerProvider initialization to service/telemetry package #9319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code will live in the otel-go-contrib `config` package instead. This PR depends on open-telemetry/opentelemetry-go-contrib#4617 Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9319 +/- ##
==========================================
- Coverage 90.34% 90.32% -0.02%
==========================================
Files 340 339 -1
Lines 17989 17859 -130
==========================================
- Hits 16253 16132 -121
+ Misses 1412 1404 -8
+ Partials 324 323 -1 ☔ View full report in Codecov by Sentry. |
codeboten
pushed a commit
that referenced
this pull request
Jan 22, 2024
TylerHelmuth
pushed a commit
to TylerHelmuth/opentelemetry-collector
that referenced
this pull request
Jan 23, 2024
A part of open-telemetry#9319 that can be done without waiting for open-telemetry#9131
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Redo of #8171
Depends on #9131
Link to tracking Issue: Updates #8170