[exporter] deprecate CreateSettings -> Settings #10335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10335 +/- ##
==========================================
- Coverage 92.57% 92.56% -0.02%
==========================================
Files 387 387
Lines 18256 18258 +2
==========================================
Hits 16900 16900
- Misses 1010 1012 +2
Partials 346 346 ☔ View full report in Codecov by Sentry. |
This deprecates CreateSettings in favour of Settings. NewNopCreateSettings is also being deprecated in favour of NewNopSettings Part of open-telemetry#9428 Signed-off-by: Alex Boten <[email protected]>
codeboten
force-pushed
the
codeboten/create-settings-exporter
branch
from
77ad8bf to
a7d60f8
Compare
songy23
reviewed
Jun 5, 2024
There was a problem hiding this comment.
A bunch of more places need to updated https://github.com/open-telemetry/opentelemetry-collector/actions/runs/9391143527/job/25862669692?pr=10335
Signed-off-by: Alex Boten <[email protected]>
atoulme
approved these changes
Jun 6, 2024
songy23
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates CreateSettings in favour of Settings. NewNopCreateSettings is also being deprecated in favour of NewNopSettings
Part of #9428
Follows #10333