[chore] Skip Unix datagram tests on Windows #37036
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanotti
added
Skip Changelog
This was referenced Jan 6, 2025
songy23
approved these changes
Jan 6, 2025
|
CI failure is fixed by #36923 |
pjanotti
added
the
ready to merge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #37036 +/- ##
==========================================
- Coverage 79.63% 79.63% -0.01%
==========================================
Files 2223 2223
Lines 210283 210283
==========================================
- Hits 167467 167459 -8
- Misses 37206 37208 +2
- Partials 5610 5616 +6 ☔ View full report in Codecov by Sentry. |
dmitryax
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skip tests that are always failing on Windows. The tests were added via #36608 but can't run on Windows..
Fixes #10151
Testing
Tested locally.