[receiver/valkey]: Init new component #37005
Conversation
This reverts commit 9898ae9.
rogercoll
force-pushed
the
init_valkey_receiver
branch
from
c3e23c0 to
a64d888
Compare
rogercoll
force-pushed
the
init_valkey_receiver
branch
from
b991b59 to
a82e488
Compare
rogercoll
force-pushed
the
init_valkey_receiver
branch
from
a82e488 to
1644903
Compare
|
cc @dmitryax |
receiver/valkeyreceiver/client.go
Outdated
| continue | ||
| } | ||
| pair := strings.Split(line, ":") | ||
| if len(pair) == 2 { // defensive, should always == 2 |
There was a problem hiding this comment.
If this expectation is broken, should we log a warning?
There was a problem hiding this comment.
Agree, I went one step further and return an error instead. If the line cannot be split with the ":" delimiter, means we are parsing an unknown input. fc0f24b
Let me know what you think
receiver/valkeyreceiver/receiver.go
Outdated
| if opts.TLSConfig, err = vs.cfg.TLS.LoadTLSConfig(context.Background()); err != nil { | ||
| return pmetric.Metrics{}, err | ||
| } | ||
| vs.client, err = newValkeyClient(opts) |
There was a problem hiding this comment.
If we're using the if ... err != nil pattern with the TLS load, we should use it again here.
| vs.client, err = newValkeyClient(opts) | |
| if vs.client, err = newValkeyClient(opts); err != nil { |
| func (vs *valkeyScraper) recordConnectionMetrics(now pcommon.Timestamp, info map[string]string) { | ||
| recordConnection := func(infoKey string, attribute metadata.AttributeValkeyClientConnectionState) { | ||
| if val, ok := info[infoKey]; ok { | ||
| if i, err := strconv.ParseInt(val, 10, 64); err == nil { |
There was a problem hiding this comment.
Makes sense fc0f24b
receiver/valkeyreceiver/client.go
Outdated
| if len(line) == 0 || strings.HasPrefix(line, "#") { | ||
| continue | ||
| } | ||
| pair := strings.Split(line, ":") |
There was a problem hiding this comment.
Should use SplitN, as values (example from unit test listener0:name=tcp,bind=*,bind=-::*,port=6379) can have : characters.
There was a problem hiding this comment.
Not sure about this one, it looks like the keys available in the info output do not contain : characters. For the shared example, listener0 is the key, while name=tcp,bind=*,bind=-::*,port=6379 is value. This parsing function is only interested in capturing the keys and any value string (can contain :).
There was a problem hiding this comment.
Changed to Cut to only split on the first delimiter instance: 1a76c23
Co-authored-by: Sam DeHaan <[email protected]>
| } | ||
|
|
||
| result, err := vs.client.retrieveInfo(ctx) | ||
| if err != nil { |
There was a problem hiding this comment.
Are there errors that should be considered differently - IE errors that show the client is no longer valid and we need to construct a new one?
| attrs := make(map[string]string) | ||
| lines := strings.Split(data, attrDelimiter) | ||
| for _, line := range lines { | ||
| if len(line) == 0 || strings.HasPrefix(line, "#") { |
There was a problem hiding this comment.
The lines with a # prefix appear to start a named section of key/value pairs. Is there a promise in the API that there will be no name conflicts across categories? If no, we may need to consider grouping the parsed pairs by category, not in one shared map.
Description
Base receiver code for the new Valkey receiver (metadata, client interface, unit and integration tests). Just the
valkey.client.connection.countmetric will be available after this PR. Based on https://github.com/open-telemetry/semantic-conventions/blob/main/docs/database/database-metrics.md#metric-dbclientconnectioncountConfiguration options: Valkey endpoint + TLS options
Link to tracking issue
Fixes #33787
Testing
testdata+ contrib golden package.Documentation