[exporter/bmchelix] New component: BMC Helix Exporter #36964
+855
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Go init * Added README.md and code skeleton.
* Updated go version to 1.22.0 in the go.mod file.
* Fixed dependency versions in go.mod
exporter/bmchelixexporter/config.go
Outdated
| if c.ApiKey == "" { | ||
| return errors.New("api key is required") | ||
| } | ||
| if c.Timeout < 0 { |
There was a problem hiding this comment.
If timeout must be a positive integer, then I think it should be if c.Timeout <= 0
* Fixed timeout positive integer check.
fatsheep9146
approved these changes
Dec 26, 2024
songy23
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new component for exporting metrics to BMC Helix. The changes include adding the new component to various configuration files, creating necessary documentation, and implementing the component's configuration and factory logic.
Key changes include:
New Component Addition:
.chloggen/bmchelixexporter-new-component.yaml..github/CODEOWNERSto include the new BMC Helix exporter.Documentation:
README.mdfor the BMC Helix exporter with detailed setup instructions and examples.Configuration and Factory Implementation:
config.go.config_test.go.factory.go.factory_test.go.Miscellaneous:
exporter/bmchelixexporter/Makefile.doc.go.Link to tracking issue
Fixes #36773