[receiver/prometheusremotewrite] validate if scope is already present #36927
+63
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurSens
reviewed
Dec 24, 2024
Comment on lines
247
to
248
| scopeExists = true | ||
| break |
There was a problem hiding this comment.
We also want to add datapoints in this case, but for the existing scope
Suggested change
| scopeExists = true | |
| break | |
| scopeExists = true | |
| addDatapoints(scope.Metrics.AppendEmpty().SetEmptyGauge().Datapoints(), ls, ts) | |
| break |
We're using Metrics.AppendEmpty() due to the first TODO in this function, in a follow up PR we'll cache metric type/unit/name and use that to decide if we append empty metrics or use an already existing one :)
There was a problem hiding this comment.
Do you think that I need to add this detail in a comment?
There was a problem hiding this comment.
Nah, the already existing TODO is enough :)
Co-authored-by: Arthur Silva Sens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuing the work done in this PR, addressing a TODO.