[connector/signatometrics]Add core logic for signal to metrics #36852
Conversation
|
[For reviewers] I am not sure what to do with the changelog for the PR. This PR adds the core logic of the component but not sure how to add this to the changelog, so I haven't added it yet. Let me know if it is needed. |
There was a problem hiding this comment.
I think a changelog would make sense, it's a user facing change that actually makes the component "functional" for the users.
I had a first look into the PR and overall looks good but I'd definitely need to do a second more careful pass on it (I assume there is no easy way to split the implementation into multiple PRs and the current one is quite big). If anybody else want to also review that'd be more than welcome.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
/label -stale |
Description
Adding core logic for the signal to metrics connector.
Link to tracking issue
Related to #35930
Testing
Unit tests added
Documentation
Documentation is already added in README.