[chore] Upgrade prometheus/common and update tls config validation #23025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TLS validation that we have was added in the prometheus library in the unmarshaling step making our validation not utilized. This change removes the duplicating validation and updates the tests.
dmitryax
requested review from
jmacd,
djaglowski,
fatsheep9146,
jpkrohling,
Aneurysm9,
dashpole,
kovrus,
mx-psi,
atoulme,
jsuereth and
songy23
as code owners
github-actions
bot
added
cmd/otelcontribcol
github-actions
bot
added
processor/probabilisticsampler
songy23
approved these changes
Jun 2, 2023
codeboten
approved these changes
Jun 2, 2023
Caleb-Hurshman
pushed a commit
to observIQ/opentelemetry-collector-contrib
that referenced
this pull request
Jul 6, 2023
…pen-telemetry#23025) The TLS validation that we have was added in the prometheus library in the unmarshaling step making our validation not utilized. This change removes the duplicating validation and updates the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TLS config validation that we have was added in the unmarshaling step in prometheus/common#472, making our validation not needed. This change removes the duplicating validation and updates the tests.
Resolves #22721
Unblocks #23023