fixing logic

Signed-off-by: odubajDT <[email protected]>

pkg/ottl/functions.go

@@ -233,12 +233,6 @@ func (p *Parser[K]) newKeys(keys []key) ([]Key[K], error) {
 				}
 				par = arg
 			}
-			if f := keys[i].Expression.Float; f != nil {
-				par = literal[K]{value: *f}
-			}
-			if i := keys[i].Expression.Int; i != nil {
-				par = literal[K]{value: *i}
-			}
 			if keys[i].Expression.Converter != nil {
 				g, err := p.newGetterFromConverter(*keys[i].Expression.Converter)
 				if err != nil {

pkg/ottl/grammar.go

@@ -270,18 +270,37 @@ type path struct {
 	Fields  []field `parser:"@@ ( '.' @@ )*"`
 }
 
+func (p *path) accept(v grammarVisitor) {
+	v.visitPath(p)
+	for _, arg := range p.Fields {
+		arg.accept(v)
+	}
+}
+
 // field is an item within a path.
 type field struct {
 	Name string `parser:"@Lowercase"`
 	Keys []key  `parser:"( @@ )*"`
 }
 
+func (f *field) accept(v grammarVisitor) {
+	for _, arg := range f.Keys {
+		arg.accept(v)
+	}
+}
+
 type key struct {
 	String     *string          `parser:"'[' (@String "`
 	Int        *int64           `parser:"| @Int"`
 	Expression *mathExprLiteral `parser:"| @@ ) ']'"`
 }
 
+func (k *key) accept(v grammarVisitor) {
+	if k.Expression != nil {
+		k.Expression.accept(v)
+	}
+}
+
 type list struct {
 	Values []value `parser:"'[' (@@)* (',' @@)* ']'"`
 }
@@ -344,7 +363,7 @@ type mathExprLiteral struct {
 func (m *mathExprLiteral) accept(v grammarVisitor) {
 	v.visitMathExprLiteral(m)
 	if m.Path != nil {
-		v.visitPath(m.Path)
+		m.Path.accept(v)
 	}
 	if m.Editor != nil {
 		m.Editor.accept(v)