Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid requiring CGO for now #71

Merged
merged 1 commit into from
Feb 3, 2024
Merged

fix: avoid requiring CGO for now #71

merged 1 commit into from
Feb 3, 2024

Conversation

dtemir
Copy link
Contributor

@dtemir dtemir commented Dec 29, 2023

Description

If your system doesn't have the gcc installed, the binary won't get built.

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

This PR fixes #70

Mobile & Desktop Screenshots/Recordings

image

Steps to QA

Try deleting gcc sudo apt-get --purge remove gcc and running make build

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Make sure the CI passes (didn't test the workflow)

[optional] What gif best describes this PR or how it makes you feel?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❀️! πŸŽ‰πŸ•
Say hello by joining the conversation in our Discord

Copy link
Member

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!! πŸ‘πŸΌ 🐹

@jpmcb jpmcb requested a review from a team February 2, 2024 19:09
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dtemir! :shipit:

Copy link

@takanome-dev takanome-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘ πŸ•Ί

@jpmcb jpmcb merged commit f6d2f1d into open-sauced:beta Feb 3, 2024
6 checks passed
open-sauced bot pushed a commit that referenced this pull request Feb 3, 2024
## [1.1.1-beta.2](v1.1.1-beta.1...v1.1.1-beta.2) (2024-02-03)

### πŸ› Bug Fixes

* avoid requiring CGO for now ([#71](#71)) ([f6d2f1d](f6d2f1d))
open-sauced bot pushed a commit that referenced this pull request Feb 5, 2024
## [1.1.1](v1.1.0...v1.1.1) (2024-02-05)

### πŸ› Bug Fixes

* avoid requiring CGO for now ([#71](#71)) ([f6d2f1d](f6d2f1d))
* Force publish of package to build go binaries during release ([#69](#69)) ([02177d5](02177d5))
* Upgrade to v2 API ([#73](#73)) ([40b468b](40b468b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Getting GLIBC not found errors on Ubuntu
4 participants