Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Check unresolved symbols when compiled with OQS_DLOPEN_OPENSSL #2058

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

ueno
Copy link
Contributor

@ueno ueno commented Jan 29, 2025

As a follow-up of commit 64bceb3, this checks that the library artifacts don't contain any unresolved symbols from libcrypto.so when it is dynamically loaded.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

As a follow-up of commit 64bceb3,
this checks that the library artifacts don't contain any unresolved
symbols from libcrypto.so when it is dynamically loaded.

Signed-off-by: Daiki Ueno <[email protected]>
Copy link
Member

@SWilson4 SWilson4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up PR! (And sorry to @baentsch for jumping the gun by merging the previous one before this test was added.)

@dstebila
Copy link
Member

@praveksharma Is the build failure on cuPQC expected here?

@praveksharma
Copy link
Member

@praveksharma Is the build failure on cuPQC expected here?

Yes, unfortunately, I think it has to do with CI image itself. Although, I'm not certain why test passed in #2044 but has been failing since. That particular test fails because CMake can't find the CUDA compiler, it shouldn't affect this PR.

@dstebila
Copy link
Member

@praveksharma Is the build failure on cuPQC expected here?

Yes, unfortunately, I think it has to do with CI image itself. Although, I'm not certain why test passed in #2044 but has been failing since. That particular test fails because CMake can't find the CUDA compiler, it shouldn't affect this PR.

Okay, I'll merge this one now.

@dstebila dstebila merged commit f877812 into open-quantum-safe:main Jan 29, 2025
67 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants