Fixing Typecast issue #879
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently cpu value is being returned as floating point, which is resulting in make command failure. Changing it to return int value. Signed-off-by: vrbagalkot <[email protected]>
abdhaleegit
requested changes
Mar 5, 2025
There was a problem hiding this comment.
Signed-off-by: vrbagalkot [email protected]
please use the imap id
abdhaleegit
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently cpu value is being returned as floating point, which is resulting in make command failure. Changing it to return int value.
Below is the snippet of the logs before and after the change.
Before:
console-expect]#make -j 9.0 -s make -j 9.0 -s make[1]: *** No rule to make target '9.0'. Stop. make: *** [Makefile:240: __sub-make] Error 2 [console-expect]#echo $? echo $? 2After this patch:
`[console-expect]#make -j 9 -s
make -j 9 -s
WRAP arch/powerpc/include/generated/uapi/asm/bpf_perf_event.h
echo "#include <asm-generic/bpf_perf_event.h>" > arch/powerpc/include/generated/uapi/asm/bpf_perf_event.h`