Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: smoother services (Fixes #7821) #7830

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

jessewashburn
Copy link
Member

Fixes #7821

I added a remove description button/function and made it so the buttons are below the content.
image
image

Editing or adding: submitting a blank description not allowed.
image
image

@jessewashburn jessewashburn linked an issue Nov 22, 2024 that may be closed by this pull request
Copy link
Member

@RheuX RheuX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, i think when clicking the remove description, we don't need the cancel button and the red trash button. Since when clicking the trash button it brings up the dialog again. I feel its to redundant since the dialog can cancel an action also.

removed redundant buttons
removed redundant method
@jessewashburn
Copy link
Member Author

jessewashburn commented Nov 27, 2024

In my opinion, i think when clicking the remove description, we don't need the cancel button and the red trash button. Since when clicking the trash button it brings up the dialog again. I feel its to redundant since the dialog can cancel an action also.

Sure, makes sense. I made those changes.

@jessewashburn
Copy link
Member Author

@Mutugiii The headers should be dynamic as of my latest commit

@jessewashburn
Copy link
Member Author

Actually, I elected to remove the big headers and just do some bolded text. Looks cleaner I think.

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Community: creating blank description allowed
3 participants