Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mylife: smoother myachievements (fixes #6429) #7753

Merged
merged 8 commits into from
Jan 7, 2025
Merged

mylife: smoother myachievements (fixes #6429) #7753

merged 8 commits into from
Jan 7, 2025
+26 −20

Conversation

sahilvunnam
Copy link
Member

fixes #6429

Image 11-8-24 at 8 04 AM

Image 11-8-24 at 8 05 AM

@sahilvunnam sahilvunnam linked an issue Nov 8, 2024 that may be closed by this pull request
myAchievements: Title is Edit Achievements while adding Achievements #6429
Closed
Gavinp14
Gavinp14 requested changes Nov 8, 2024
View reviewed changes
Copy link
Member

@Gavinp14 Gavinp14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is showing "Add Achievements for a brief second and then immediately goes back to saying "edit achievements".

RheuX
RheuX reviewed Nov 8, 2024
View reviewed changes
Copy link
Member

@RheuX RheuX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh gavin is right, its loading the page first, then updating the title after it gets the data, thats why its a 0.1 second change

@sahilvunnam sahilvunnam requested a review from Gavinp14 November 12, 2024 16:12
Mutugiii
Mutugiii reviewed Nov 14, 2024
View reviewed changes
Copy link
Member

@Mutugiii Mutugiii left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to view the Add Achievements

image

@dogi dogi changed the title achievements: smoother view (fixes #6429) mylife: smoother achievements view (fixes #6429) Dec 13, 2024
@jessewashburn jessewashburn self-assigned this Dec 17, 2024
@dogi dogi changed the title mylife: smoother achievements view (fixes #6429) mylife: smoother myachievements (fixes #6429) Jan 7, 2025
@dogi dogi merged commit c6797c0 into master Jan 7, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gavinp14 Gavinp14 Gavinp14 approved these changes

@RheuX RheuX RheuX approved these changes

@Mutugiii Mutugiii Mutugiii approved these changes

@dogi dogi dogi approved these changes

Assignees

@jessewashburn jessewashburn

Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

myAchievements: Title is Edit Achievements while adding Achievements
6 participants
@sahilvunnam @dogi @Mutugiii @RheuX @Gavinp14 @jessewashburn