teams: less notify dataset changed is more (fixes #11713)#11639
Conversation
…ter and RequestsAdapter Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Okuro3499
left a comment
There was a problem hiding this comment.
The cleanest fix is to simply remove the submitList call entirely and just update the field. The field change takes effect on the very next updateData/setData call that always follows:
// MembersAdapter.kt
fun setUserId(userId: String?) {
this.currentUserId = userId
// no notify needed — caller always follows with updateData()
}
// RequestsAdapter.kt
fun setUser(user: RealmUser) {
this.currentUser = user
// no notify needed — caller always follows with setData()
}
…dapter Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
This change replaces full UI resets using
notifyDataSetChanged()with efficient differential updates usingsubmitList(currentList.toList())inMembersAdapter.setUserIdandRequestsAdapter.setUser. This triggersDiffUtiloptimally to compute and display changes.PR created automatically by Jules for task 18297643814926361048 started by @dogi