Skip to content

teams: less notify dataset changed is more (fixes #11713)#11639

Merged
dogi merged 4 commits intomasterfrom
fix-adapter-notify-18297643814926361048
Mar 4, 2026
Merged

teams: less notify dataset changed is more (fixes #11713)#11639
dogi merged 4 commits intomasterfrom
fix-adapter-notify-18297643814926361048

Conversation

@dogi
Copy link
Member

@dogi dogi commented Mar 2, 2026

This change replaces full UI resets using notifyDataSetChanged() with efficient differential updates using submitList(currentList.toList()) in MembersAdapter.setUserId and RequestsAdapter.setUser. This triggers DiffUtil optimally to compute and display changes.


PR created automatically by Jules for task 18297643814926361048 started by @dogi

…ter and RequestsAdapter

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cleanest fix is to simply remove the submitList call entirely and just update the field. The field change takes effect on the very next updateData/setData call that always follows:

// MembersAdapter.kt
fun setUserId(userId: String?) {
this.currentUserId = userId
// no notify needed — caller always follows with updateData()
}

// RequestsAdapter.kt
fun setUser(user: RealmUser) {
this.currentUser = user
// no notify needed — caller always follows with setData()
}

…dapter

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@dogi dogi requested a review from Okuro3499 March 3, 2026 14:30
@dogi dogi changed the title Refactor: Replace notifyDataSetChanged with submitList in MembersAdapter and RequestsAdapter all: less notify dataset changed is more (fixes #11713) Mar 4, 2026
@dogi dogi changed the title all: less notify dataset changed is more (fixes #11713) teams: less notify dataset changed is more (fixes #11713) Mar 4, 2026
@dogi dogi merged commit 432bd5f into master Mar 4, 2026
3 checks passed
@dogi dogi deleted the fix-adapter-notify-18297643814926361048 branch March 18, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants