teams: smoother repository summary modelling (fixes #11710)#11631
teams: smoother repository summary modelling (fixes #11710)#11631
Conversation
…toryFragment - Created `TeamSummary` data class to serve as a boundary-safe POJO for `RealmMyTeam`. - Added `getTeamSummaries()` boundary method to `TeamsRepository` and `TeamsRepositoryImpl`. - Deprecated `getShareableTeams()` in `TeamsRepository`. - Migrated `ChatHistoryFragment` and related components (`ChatShareTargets`, `ChatHistoryAdapter`, `TeamsSelectionAdapter`) to use `TeamSummary`. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Okuro3499
left a comment
Okuro3499
left a comment
There was a problem hiding this comment.
- Extend ChatShareTargets.enterprises and .community to use TeamSummary/TeamSummary? and move the conversion to the repository (add getEnterprisesSummaries() or a unified getShareTargets() method). Remove the inline mapping from the click handler.
- Either give getTeamSummaries() its own Realm query scoped to the needed fields, or add a code comment explicitly stating that the delegation is intentional and only for type isolation.
- Refactored `ChatShareTargets` so `enterprises` and `community` use `TeamSummary`. - Added `getShareableEnterpriseSummaries` and `getTeamSummaryById` to `TeamsRepository` and `TeamsRepositoryImpl` with explicit delegation comments. - Removed inline mapping logic from `ChatHistoryAdapter`'s click handlers, passing `TeamSummary` models directly from the repository layer. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
dogi
changed the title
dogi
changed the title
2 participants
This commit introduces a boundary-safe
TeamSummarymodel and updatesTeamsRepositoryto return this model alongside deprecating the direct Realm-returning methodgetShareableTeams(). It selectively updatesChatHistoryFragmentand its associated adapters to consume the newTeamSummarydata class, decoupling the presentation layer from the Realm database.PR created automatically by Jules for task 8006425631081337400 started by @dogi