teams: smoother resources inline list adapting (fixes #11709)#11628
teams: smoother resources inline list adapting (fixes #11709)#11628
Conversation
- Swapped `RecyclerView.Adapter` with `ListAdapter` in `InlineResourceAdapter`. - Implemented `ResourceDiffCallback` to verify identity and check contents based on multiple resource properties. - Removed custom `updateResources` method and direct item tracking array. - Updated `CourseStepFragment` to construct adapter without initial list and replaced updates with `submitList`. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
❌ 1 blocking issue (1 total)
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
| } | ||
|
|
||
| override fun areContentsTheSame(oldItem: RealmMyLibrary, newItem: RealmMyLibrary): Boolean { | ||
| return oldItem._rev == newItem._rev && |
dogi
changed the title
Okuro3499
deleted the
refactor-inline-resource-adapter-4222589206159881372
branch
2 participants
Converted
InlineResourceAdapterto inherit fromListAdapterutilizingDiffUtil.ItemCallback(viaResourceDiffCallback) for more efficient list updates. Kept all original view binding logics intact. UpdatedCourseStepFragmentaccordingly.PR created automatically by Jules for task 4222589206159881372 started by @dogi