Skip to content

Refactor Health Upload Realm Queries to HealthRepository#11626

Closed
dogi wants to merge 1 commit intomasterfrom
refactor-health-repository-upload-13185437995499689068
Closed

Refactor Health Upload Realm Queries to HealthRepository#11626
dogi wants to merge 1 commit intomasterfrom
refactor-health-repository-upload-13185437995499689068

Conversation

@dogi
Copy link
Copy Markdown
Member

@dogi dogi commented Mar 2, 2026

Refactors UploadToShelfService to remove direct Realm access for health data uploads, delegating these operations to HealthRepository.


PR created automatically by Jules for task 13185437995499689068 started by @dogi

…epository

Extract direct Realm database queries in UploadToShelfService into HealthRepository.
- Add `getUpdatedHealthExaminations` to retrieve unmanaged, updated RealmHealthExamination objects.
- Add `markHealthUploaded` to safely mark an examination as uploaded and update its `_rev`.
- Update UploadToShelfService methods `uploadHealth` and `uploadSingleUserHealth` to use the new repository methods instead of direct Realm transactions.
- Inject HealthRepository into UploadToShelfService via ServiceModule.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@dogi dogi added the triage Further information is requested label Mar 2, 2026
@qltysh
Copy link
Copy Markdown

qltysh bot commented Mar 2, 2026

❌ 3 blocking issues (3 total)

Tool Category Rule Count
qlty Duplication Found 15 lines of similar code in 2 locations (mass = 143) 2
qlty Structure Function with many parameters (count = 7): provideUploadToShelfService 1

coursesRepository: org.ole.planet.myplanet.repository.CoursesRepository,
userRepository: org.ole.planet.myplanet.repository.UserRepository
userRepository: org.ole.planet.myplanet.repository.UserRepository,
healthRepository: org.ole.planet.myplanet.repository.HealthRepository
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 7): provideUploadToShelfService [qlty:function-parameters]

@dogi dogi closed this Mar 3, 2026
@dogi dogi deleted the refactor-health-repository-upload-13185437995499689068 branch March 18, 2026 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

close? triage Further information is requested ⭐⭐⭐.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants