chore: changing error hook api to contain object #1525
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aepfli
force-pushed
the
demo/Errordetails_instead_of_exception
branch
from
f4e94d4 to
d717373
Compare
aepfli
changed the title
aepfli
force-pushed
the
demo/Errordetails_instead_of_exception
branch
from
d717373 to
ebcb5f4
Compare
This is a fast demo of open-feature/spec#326 As errors in the flag evaluation do not have to be exceptions, this opens up improvements for flow control via error codes from the EvaluationDetails. Signed-off-by: Simon Schrottner <[email protected]>
aepfli
force-pushed
the
demo/Errordetails_instead_of_exception
branch
from
ebcb5f4 to
ec55588
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1525 +/- ##
============================================
+ Coverage 92.81% 93.31% +0.49%
- Complexity 486 491 +5
============================================
Files 46 47 +1
Lines 1169 1181 +12
Branches 103 102 -1
============================================
+ Hits 1085 1102 +17
+ Misses 54 49 -5
Partials 30 30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fast demo of open-feature/spec#326
As errors in the flag evaluation do not have to be exceptions, this opens up improvements for flow control via error codes from the EvaluationDetails.