feat: flagd provider creates named daemon threads for error executor

[jarebudev]

This PR

Enables the flagd provider to create descriptively named daemon threads, similar to the changes made in open-feature/java-sdk#1633

Related Issues

Resolves #1599

[gemini-code-assist]

Summary of Changes

Hello @jarebudev, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the flagd provider by implementing a custom ThreadFactory to assign descriptive names to the daemon threads used by its internal error executor. This change significantly improves the debuggability and observability of the provider, as these background threads will now be easily identifiable in thread dumps and monitoring tools, aligning with similar improvements made in other parts of the Java SDK.

Highlights

• Custom Thread Factory: A new FlagdThreadFactory has been introduced to enable the creation of descriptively named daemon threads, improving thread identification.
• Error Executor Naming: The FlagdProvider's errorExecutor now utilizes the FlagdThreadFactory to ensure its background threads have meaningful and unique names.
• Test Coverage: Comprehensive unit tests have been added for the FlagdThreadFactory to validate its thread naming and daemon thread behavior.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a FlagdThreadFactory to create named daemon threads for the error executor in the FlagdProvider. This is a good improvement for debuggability, as it makes it easier to identify these threads. The implementation is straightforward and includes relevant unit tests. I have a couple of suggestions to improve maintainability and robustness.

[gemini-code-assist]

The string literal "flagd-provider-thread" is duplicated on line 108. To improve maintainability and avoid magic strings, consider extracting it into a private static final constant at the class level. For example: private static final String ERROR_EXECUTOR_THREAD_NAME_PREFIX = "flagd-provider-thread";

[gemini-code-assist]

The constructor doesn't validate if namePrefix is null. If a null value is passed, it will lead to a NullPointerException later in the newThread method. It's good practice to validate arguments in the constructor to fail-fast by using Objects.requireNonNull.

Suggested change

	this.namePrefix = namePrefix;
	this.namePrefix = java.util.Objects.requireNonNull(namePrefix, "namePrefix must not be null");