Skip to content

Allow overriding of InteractivePlot elements #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

joschaschmiedt
Copy link

@joschaschmiedt joschaschmiedt commented Jun 23, 2025

Making InteractivePlot::plot as well as XYLine::draw virtual allows re-using them in custom visualizer plugins. This would be very useful for adjusting the way how things are displayed.

Making InteractivePlot::plot virtual as well as XYLine::draw allows
re-using them in custom plugins.
@anjaldoshi anjaldoshi changed the base branch from main to development June 23, 2025 17:41
@anjaldoshi
Copy link
Member

Thanks for making these updates. Making InteractivePlot::plot and XYLine::draw virtual will definitely make it easier to customize how plots are rendered in plugins that rely on the InteractivePlot class.

While this does introduce a breaking change to the PLUGIN_API that would prevent existing plugins using InteractivePlot from loading, it's currently only used by the Spectrum Viewer plugin which we can re-deploy for v1.0 after merging these changes. So we’re fine to go ahead with the merge.

@anjaldoshi anjaldoshi merged commit f422bbc into open-ephys:development Jun 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants