Document the purpose of the Rhs2116Trigger's double input
#241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparks13
reviewed
Jun 6, 2025
There was a problem hiding this comment.
I'm not sure I agree with saying this is a two-part sequence. I think it is more clear to say something along the lines of "it sends that double to the headstage, where the stimulus waveform (as configured in the Headstage RHS2116 GUI) is triggered after waiting N microseconds, where N is the value of the double received.".
At least this is how I've interpreted what the hardware is doing, but if your original version is more accurate then we should definitely keep it that way. Something about calling it a two-part sequence feels wrong, but that could be just a personal bias.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #179