Markdown Help Changes and Translating #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update markdown help to our limits of MD. - Fix translations not working for our setup. - Translate the actual popup contents.
- Added change log file.
wardi
approved these changes
Oct 11, 2024
|
CKAN 2.10 branch has this in the cleanup in ckan and ckanext-canada for this change has been done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(templates): markdown help;
Dependent: open-data/ckanext-canada#1520
Background
we are no longer allowing headings in our markdown rendering for a11y purposes. So excluding that from the help popup and replacing it with some more useful things. Also removing the "full markdown" doc link as the markdown render does not support a lot of the stuff found in the markdown docs, so better to not send the user there. E.g. they find tables and try to make a markdown table etc., these don't render in CKAN. Just added some more generic things that users can use like numbered lists, formatted links, and block quotes.