New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datastore Dump XML Element Names #180

Merged

JVickery-TBS merged 6 commits into canada-py3 from fix/ds-writer-xml-element-names

Jul 12, 2024

JVickery-TBS commented Jul 11, 2024

Fix/ds writer xml element names

Added regex substitutions for XML element names.


          feat(logic): ds dump xml rules;

- Added regex substitutions for XML element names.

JVickery-TBS added the enhancement label

JVickery-TBS requested a review from wardi

July 11, 2024 18:38

JVickery-TBS assigned wardi and JVickery-TBS


          feat(misc) changelog;

f2a52a6

- Added change log file.

wardi reviewed

View reviewed changes

ckanext/datastore/writer.py Outdated Show resolved Hide resolved

wardi reviewed

View reviewed changes

ckanext/datastore/writer.py Outdated Show resolved Hide resolved

wardi reviewed

View reviewed changes

ckanext/datastore/writer.py Outdated Show resolved Hide resolved

wardi reviewed

View reviewed changes

ckanext/datastore/writer.py Outdated Show resolved Hide resolved

JVickery-TBS and others added 2 commits

July 12, 2024 11:10


          Update ckanext/datastore/writer.py

2cf7939

Co-authored-by: Ian Ward <[email protected]>


          fix(logic): ds xml dump;

29fea16

- Added in accented characters to allow list.
- Used space special char.
- Added uniqueness to the element names after regex substitutions.

JVickery-TBS requested a review from wardi

July 12, 2024 15:44

wardi reviewed

View reviewed changes

ckanext/datastore/writer.py Outdated Show resolved Hide resolved

wardi reviewed

View reviewed changes

ckanext/datastore/writer.py Show resolved Hide resolved


          fix(logic): ds xml dump;

721bbc7

- Added rule to start with underscore or letter.

JVickery-TBS requested a review from wardi

July 12, 2024 16:42

wardi approved these changes

View reviewed changes

Member

wardi left a comment

Looks good. unicodedata.normalize('NFC', …) would future-proof this code but is also something we could enforce when creating the columns in the datastore.

Good for upstream too.

Author

JVickery-TBS commented Jul 12, 2024

@wardi would the unicodedata.normalize('NFC', …) happen in the XML writer when building the element_names dict?

Member

wardi commented Jul 12, 2024

Yes, just before replacing word characters so the regex works regardless of the source normalization


          fix(logic): ds xml dump;

1e26b08

- Normalize string.

JVickery-TBS merged commit 0018caa into canada-py3

1 check passed

JVickery-TBS deleted the fix/ds-writer-xml-element-names branch

July 12, 2024 17:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels