Single layer OCI Artifact ADR #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frewilhelm
force-pushed
the
adr_artifacts
branch
2 times, most recently
from
7fa56ce to
3797630
Compare
frewilhelm
force-pushed
the
adr_artifacts
branch
2 times, most recently
from
f353463 to
6615438
Compare
2 tasks
Skarlso
reviewed
Jan 21, 2025
Skarlso
reviewed
Jan 22, 2025
Skarlso
reviewed
Jan 22, 2025
Skarlso
reviewed
Jan 22, 2025
Skarlso
reviewed
Jan 22, 2025
Skarlso
reviewed
Jan 22, 2025
Skarlso
reviewed
Jan 22, 2025
Skarlso
reviewed
Jan 22, 2025
Skarlso
reviewed
Jan 22, 2025
Skarlso
reviewed
Jan 22, 2025
Skarlso
reviewed
Jan 22, 2025
frewilhelm
force-pushed
the
adr_artifacts
branch
from
108ac97 to
ae3941f
Compare
fabianburth
reviewed
Jan 23, 2025
fabianburth
reviewed
Jan 23, 2025
fabianburth
reviewed
Jan 23, 2025
fabianburth
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Good job here on the proposal overall. Im mostly concerned that some of the options seem to be presented with points I couldnt follow up on. Nevertheless Im assuming that taking over the snapshot implementation (with heavy adjustments) is an acceptable solution
frewilhelm
requested review from
jakobmoellerdev,
Skarlso,
ikhandamirov and
fabianburth
frewilhelm
force-pushed
the
adr_artifacts
branch
2 times, most recently
from
96033a0 to
530cad8
Compare
hilmarf
previously approved these changes
Jan 28, 2025
Co-authored-by: Fabian Burth <[email protected]>
Co-authored-by: Fabian Burth <[email protected]>
frewilhelm
force-pushed
the
adr_artifacts
branch
from
debb87c to
ce5c85d
Compare
fabianburth
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #90