Skip to content

Remove compliance summary os id #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Remove compliance summary os id #427

wants to merge 4 commits into from

Conversation

TuanAnh17N
Copy link
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Remove legacy OSId scans after migration to dedicated ODG extension

@TuanAnh17N TuanAnh17N requested a review from a team as a code owner April 25, 2025 12:35
@zkdev zkdev self-requested a review April 28, 2025 08:23
zkdev
zkdev approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@zkdev zkdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

8R0WNI3
8R0WNI3 reviewed Apr 28, 2025
View reviewed changes
Copy link
Member

@8R0WNI3 8R0WNI3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also remove all remaining occurrences of the old finding type os_ids, e.g. in odg.findings:

git grep os_ids

@ccwienk
Copy link
Collaborator

ccwienk commented Apr 28, 2025 •
edited
Loading

@8R0WNI3 : in that case:
/hold
Edit: apparently, gardener-robot does not watch this organisation/repository <.<

@TuanAnh17N TuanAnh17N force-pushed the remove-compliance-summary-os-id branch from bb89305 to 5769899 Compare April 28, 2025 13:11
@TuanAnh17N
Copy link
Collaborator Author

osid_extension/util.py:14: [E] E1101 Module 'dso.model' has no 'OperatingSystemId' member [pylint]

tests are failing because we first need to get this merged -> release cc-utils -> upgrade the reference here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@8R0WNI3 8R0WNI3 8R0WNI3 left review comments

@ccwienk ccwienk ccwienk approved these changes

@zkdev zkdev zkdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TuanAnh17N @ccwienk @zkdev @8R0WNI3