Add ODG controller #411
Open
Add ODG controller #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocm-ci-robot-0
added
reviewed/ok-to-test
ccwienk
requested changes
Apr 8, 2025
| import odg_operator.odg_model as odgm | ||
|
|
||
|
|
||
| ci.log.configure_default_logging() |
There was a problem hiding this comment.
I would prefer to new code to avoid dependencies to ci.* packages. esp. sth. basic like logging we should rather define locally (esp. considering that we might see a different logging infrastructure for ODG - e.g. conveying logs to some service, rather than (only) printing to stdout).
zkdev
force-pushed
the
zkdev-odg-controller
branch
3 times, most recently
from
218d87a to
484d21a
Compare
8R0WNI3
reviewed
May 5, 2025
odg_operator/odg_controller.py
Outdated
| logger.info(f'{event["type"]} "{odg_name}" in "{metadata["namespace"]}"') | ||
|
|
||
| requested_extension_definitions = [ | ||
| find_extension_definition( |
There was a problem hiding this comment.
In order to support external extension definitions as well, we have to specify a fallback here in case the extension is not find in "our" definitions.
There was a problem hiding this comment.
so we would need something like:
dependencies:
- name: custom-extension
type: custom
component_name: my-custom.component.foo
component_version: 0.1.0
artefact_name: my-artefact
- name: delivery-service
type: supportedwdyt?
zkdev
force-pushed
the
zkdev-odg-controller
branch
3 times, most recently
from
1f189d5 to
1fb1b1a
Compare
Reconciles ODG resources in mODG-root cluster and creates ODG-Extension resources (via gardener-resource-manager).
zkdev
force-pushed
the
zkdev-odg-controller
branch
from
1fb1b1a to
9b20804
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reconciles ODG resources in mODG-root cluster and creates ODG-Extension resources (via gardener-resource-manager).
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: