Skip to content

remove legacy os id code #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

remove legacy os id code #330

merged 1 commit into from
May 9, 2025

Conversation

TuanAnh17N
Copy link
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Remove legacy os id code

@TuanAnh17N TuanAnh17N requested a review from a team as a code owner April 25, 2025 14:12
@ocm-ci-robot-0 ocm-ci-robot-0 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 25, 2025
zkdev
zkdev previously approved these changes Apr 28, 2025
Copy link
Member

@zkdev zkdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TuanAnh17N TuanAnh17N force-pushed the remove-legacy-osid branch from be1bfa3 to a3b3b4a Compare May 9, 2025 13:37
@ocm-ci-robot-0 ocm-ci-robot-0 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 9, 2025
@TuanAnh17N TuanAnh17N force-pushed the remove-legacy-osid branch from a3b3b4a to 0646af4 Compare May 9, 2025 13:40
@ocm-ci-robot-0 ocm-ci-robot-0 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 9, 2025
Copy link
Member

@8R0WNI3 8R0WNI3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TuanAnh17N TuanAnh17N merged commit 5038f1c into master May 9, 2025
2 checks passed
@TuanAnh17N TuanAnh17N deleted the remove-legacy-osid branch May 9, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants