daily update vLLM&vLLM-fork version #1914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sun, Xuehao <[email protected]>
XuehaoSun
requested review from
ashahba,
lkk12014402,
minmin-intel,
rbrugaro,
letonghan,
Spycsh,
lvliang-intel,
WenjiaoYue,
chensuyue and
ZePan110
as code owners
Dependency Review✅ No vulnerabilities or license issues found.Scanned Files
|
There was a problem hiding this comment.
Pull Request Overview
This PR implements a daily update workflow to automatically update both the vLLM and vLLM-fork version tags. It introduces a new workflow file to perform the update and adjusts the build image workflow to use the vLLM-fork version.
Reviewed Changes
Copilot reviewed 2 out of 12 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/update-vllm-version.yml | Adds a new workflow to fetch the latest vLLM and vLLM-fork tags and create/update a PR. |
| .github/workflows/_build_image.yml | Updates the version checkout to use vLLM-fork and adjusts corresponding echo messages. |
Files not reviewed (10)
- AgentQnA/tests/step1_build_images.sh: Language not supported
- AudioQnA/tests/test_compose_on_gaudi.sh: Language not supported
- ChatQnA/tests/test_compose_faqgen_on_gaudi.sh: Language not supported
- ChatQnA/tests/test_compose_guardrails_on_gaudi.sh: Language not supported
- ChatQnA/tests/test_compose_on_gaudi.sh: Language not supported
- ChatQnA/tests/test_compose_without_rerank_on_gaudi.sh: Language not supported
- CodeGen/tests/test_compose_on_gaudi.sh: Language not supported
- CodeTrans/tests/test_compose_on_gaudi.sh: Language not supported
- DocSum/tests/test_compose_on_gaudi.sh: Language not supported
- FinanceAgent/tests/test_compose_on_gaudi.sh: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/_build_image.yml:87
- [nitpick] For consistency with the variable name, consider updating the echo message to 'Check out vLLM-fork tag ${VLLM_FORK_VER}'.
echo "Check out vLLM tag ${VLLM_FORK_VER}"
Signed-off-by: Sun, Xuehao <[email protected]>
Signed-off-by: Sun, Xuehao <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a daily update workflow to refresh the vLLM and vLLM-fork versions in the project repositories. Key changes include the addition of a new GitHub Actions workflow for version updates, updates to version replacement commands using sed, and modifications to the image build workflow to check out the appropriate vLLM-fork tag.
Reviewed Changes
Copilot reviewed 2 out of 12 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/daily-update-vllm-version.yml | New workflow file for automating daily version updates in the project. |
| .github/workflows/_build_image.yml | Adjusted checkout logic to use the vLLM-fork version for image builds. |
Files not reviewed (10)
- AgentQnA/tests/step1_build_images.sh: Language not supported
- AudioQnA/tests/test_compose_on_gaudi.sh: Language not supported
- ChatQnA/tests/test_compose_faqgen_on_gaudi.sh: Language not supported
- ChatQnA/tests/test_compose_guardrails_on_gaudi.sh: Language not supported
- ChatQnA/tests/test_compose_on_gaudi.sh: Language not supported
- ChatQnA/tests/test_compose_without_rerank_on_gaudi.sh: Language not supported
- CodeGen/tests/test_compose_on_gaudi.sh: Language not supported
- CodeTrans/tests/test_compose_on_gaudi.sh: Language not supported
- DocSum/tests/test_compose_on_gaudi.sh: Language not supported
- FinanceAgent/tests/test_compose_on_gaudi.sh: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/_build_image.yml:87
- [nitpick] The echoed message still refers to 'vLLM tag' even though the variable name is VLLM_FORK_VER, which may lead to confusion. Please update the message to clearly indicate that it is using the vLLM-fork version.
echo "Check out vLLM tag ${VLLM_FORK_VER}"
Signed-off-by: Sun, Xuehao <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a daily update workflow to automatically fetch and update the vLLM and vLLM-fork version tags used in the repository. The changes include adding a new workflow file (.github/workflows/daily-update-vllm-version.yml) to manage version updates and modifying the build image workflow (.github/workflows/_build_image.yml) to checkout the correct vLLM-fork version.
Reviewed Changes
Copilot reviewed 2 out of 12 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/daily-update-vllm-version.yml | Adds a daily update workflow to pull the latest vLLM and vLLM-fork tags and updates the version variables in relevant files. |
| .github/workflows/_build_image.yml | Adjusts the checkout step for vLLM-fork by replacing a hardcoded version variable and log message. |
Files not reviewed (10)
- AgentQnA/tests/step1_build_images.sh: Language not supported
- AudioQnA/tests/test_compose_on_gaudi.sh: Language not supported
- ChatQnA/tests/test_compose_faqgen_on_gaudi.sh: Language not supported
- ChatQnA/tests/test_compose_guardrails_on_gaudi.sh: Language not supported
- ChatQnA/tests/test_compose_on_gaudi.sh: Language not supported
- ChatQnA/tests/test_compose_without_rerank_on_gaudi.sh: Language not supported
- CodeGen/tests/test_compose_on_gaudi.sh: Language not supported
- CodeTrans/tests/test_compose_on_gaudi.sh: Language not supported
- DocSum/tests/test_compose_on_gaudi.sh: Language not supported
- FinanceAgent/tests/test_compose_on_gaudi.sh: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/_build_image.yml:87
- [nitpick] The echo message refers to 'vLLM tag' while using the VLLM_FORK_VER variable; consider updating it to 'Check out vLLM-fork tag ${VLLM_FORK_VER}' for clarity.
echo "Check out vLLM tag ${VLLM_FORK_VER}"
chensuyue
reviewed
May 7, 2025
Signed-off-by: Sun, Xuehao <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the CI workflows by adding a daily update action and updating the version handling for both vLLM and vLLM-fork repositories.
- Introduces a new GitHub Actions workflow (.github/workflows/daily-update-vllm-version.yml) that automatically updates version tags for vLLM and vLLM-fork.
- Updates the build image workflow (.github/workflows/_build_image.yml) to use a new variable (VLLM_FORK_VER) for checking out the appropriate version in the vLLM-fork repository.
Reviewed Changes
Copilot reviewed 2 out of 12 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/daily-update-vllm-version.yml | New workflow added for daily version updates for vLLM and vLLM-fork |
| .github/workflows/_build_image.yml | Updates version variable from VLLM_VER to VLLM_FORK_VER in checkout script; echo message may need to reflect the correct repository context |
Files not reviewed (10)
- AgentQnA/tests/step1_build_images.sh: Language not supported
- AudioQnA/tests/test_compose_on_gaudi.sh: Language not supported
- ChatQnA/tests/test_compose_faqgen_on_gaudi.sh: Language not supported
- ChatQnA/tests/test_compose_guardrails_on_gaudi.sh: Language not supported
- ChatQnA/tests/test_compose_on_gaudi.sh: Language not supported
- ChatQnA/tests/test_compose_without_rerank_on_gaudi.sh: Language not supported
- CodeGen/tests/test_compose_on_gaudi.sh: Language not supported
- CodeTrans/tests/test_compose_on_gaudi.sh: Language not supported
- DocSum/tests/test_compose_on_gaudi.sh: Language not supported
- FinanceAgent/tests/test_compose_on_gaudi.sh: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/_build_image.yml:87
- [nitpick] The echo message refers to 'vLLM tag' while using the VLLM_FORK_VER variable. Consider updating the message to 'Check out vLLM-fork tag' for clarity and consistency.
echo "Check out vLLM tag ${VLLM_FORK_VER}"
chensuyue
approved these changes
May 8, 2025
ZePan110
approved these changes
May 8, 2025
yongfengdu
pushed a commit
to yongfengdu/GenAIExamples
that referenced
this pull request
May 8, 2025
Signed-off-by: Sun, Xuehao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
daily update vLLM&vLLM-fork version
Issues
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
n/a.Tests
n/a.