Skip to content

Fix nightly test can not canceled issue #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

ZePan110
Copy link
Collaborator

@ZePan110 ZePan110 commented May 6, 2025

Description

Fix nightly test can not canceled issue

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

https://github.com/opea-project/GenAIExamples/actions/runs/14854945974

Signed-off-by: ZePan110 <[email protected]>
@Copilot Copilot AI review requested due to automatic review settings May 6, 2025 08:20
@ZePan110 ZePan110 requested a review from chensuyue as a code owner May 6, 2025 08:20
Copy link

github-actions bot commented May 6, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses an issue with the nightly test cancellation behavior by updating the workflow configuration.

  • Update the EXAMPLES environment variable to a hard-coded value ("CodeGen,CodeTrans")
  • Change the publish job condition from "always()" to "success()" to adjust when the publish step is executed
Comments suppressed due to low confidence (2)

.github/workflows/nightly-docker-build-publish.yml:12

  • Hardcoding the EXAMPLES values may bypass dynamic configuration intended by the original variable; please verify that this change is deliberate and does not negatively impact other workflow behavior.
EXAMPLES: CodeGen,CodeTrans #${{ vars.NIGHTLY_RELEASE_EXAMPLES }}

.github/workflows/nightly-docker-build-publish.yml:78

  • Changing the condition from always() to success() might prevent the publish step from running in cases where previous steps fail or are cancelled; confirm that this new trigger condition meets the intended workflow requirements for handling cancellations.
if: ${{ success() }}

@ZePan110 ZePan110 changed the title Fix nightly test can not cancel issue Fix nightly test can not canceled issue May 6, 2025
@@ -9,7 +9,7 @@ on:
workflow_dispatch:

env:
EXAMPLES: ${{ vars.NIGHTLY_RELEASE_EXAMPLES }}
EXAMPLES: CodeGen,CodeTrans #${{ vars.NIGHTLY_RELEASE_EXAMPLES }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove test code.

@ZePan110 ZePan110 closed this May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants