-
Notifications
You must be signed in to change notification settings - Fork 280
Refine README.MD for MultimodalQnA on AMD ROCm platform #1898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
artem-astafev
wants to merge
6
commits into
opea-project:main
Choose a base branch
from
artem-astafev:feature/multimodal-redefine-readme-for-rocm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refine README.MD for MultimodalQnA on AMD ROCm platform #1898
artem-astafev
wants to merge
6
commits into
opea-project:main
from
artem-astafev:feature/multimodal-redefine-readme-for-rocm
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Signed-off-by: Artem Astafev <[email protected]>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
for more information, see https://pre-commit.ci
Signed-off-by: Artem Astafev <[email protected]>
…/github.com/artem-astafev/GenAIExamples into feature/multimodal-redefine-readme-for-rocm
|
||
- #### Create application install directory and go to it: | ||
This section describes how to quickly deploy and test the MultimodalQnAservice manually on an AMD ROCm GPU. The basic steps are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MultimodalQnAservice ==> MultimodalQnA Service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- MultimodalQnA/docker_compose/amd/gpu/rocm/set_env_vllm.sh: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refine readme of MultimodalQnA for AMD ROCm docker compose deployment
Issues
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
None
Tests
None