Skip to content

Nginx Root User and Port issue Fix: ProductivitySuite #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sgurunat
Copy link
Contributor

Description

This change is related to below mentioned issues on root user and nginx port. I have updated GenAIComps nginx which is a dependency for this PR.
Have updated ProductivitySuite to use nginx server to route to different services. Updated relevant docker compose file and readme. Removed env.sh file which needed root user. For ProductivitySuite all the routings will happen via nginx server.

Issues

This change is related to below issues:
#517
#503

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

This PR depends on GenAIComps changes made for nginx. Dependency PR: opea-project/GenAIComps#1636

Tests

Tested all the features of ProductivitySuite

…nginx harcoded port issue will be fixed. Removed env.sh in UI which needs root user, also used nginx-unprivileged image which uses non root user. Updated docker compose file and readme accordingly

Signed-off-by: Gurunath S <[email protected]>
@Copilot Copilot AI review requested due to automatic review settings April 29, 2025 08:01
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issues related to running ProductivitySuite as root and port conflicts by updating the nginx configuration and routing setup.

  • Updated docker compose file to include a new nginx service (productivity-suite-nginx-server) with relevant environment variables and dependency settings.
  • Modified the README to reflect the new nginx routing and remove outdated environment variable definitions.

Reviewed Changes

Copilot reviewed 2 out of 7 changed files in this pull request and generated no comments.

File Description
ProductivitySuite/docker_compose/intel/cpu/xeon/compose.yaml Added a new nginx service configuration and updated environment variables for better service routing.
ProductivitySuite/docker_compose/intel/cpu/xeon/README.md Updated documentation to explain the new nginx routing and removed references to deprecated environment variables.
Files not reviewed (5)
  • ProductivitySuite/docker_compose/intel/cpu/xeon/set_env.sh: Language not supported
  • ProductivitySuite/ui/docker/Dockerfile.react: Language not supported
  • ProductivitySuite/ui/react/.env.production: Language not supported
  • ProductivitySuite/ui/react/env.sh: Language not supported
  • ProductivitySuite/ui/react/package.json: Language not supported

Copy link

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

@xiguiw
Copy link
Collaborator

xiguiw commented Apr 30, 2025

@sgurunat

Please fix the CI issue

mongo Pulling

[523](https://github.com/opea-project/GenAIExamples/actions/runs/14726304719/job/41329674634?pr=1893#step:6:524) productivity-suite-nginx-server Error manifest for opea/nginx:ci not found: manifest unknown: manifest unknown

[524](https://github.com/opea-project/GenAIExamples/actions/runs/14726304719/job/41329674634?pr=1893#step:6:525) mongo Error context canceled

[525](https://github.com/opea-project/GenAIExamples/actions/runs/14726304719/job/41329674634?pr=1893#step:6:526) redis-vector-db Error context canceled

[526](https://github.com/opea-project/GenAIExamples/actions/runs/14726304719/job/41329674634?pr=1893#step:6:527) keycloak Error context canceled

[527](https://github.com/opea-project/GenAIExamples/actions/runs/14726304719/job/41329674634?pr=1893#step:6:528)Error response from daemon: manifest for opea/nginx:ci not found: manifest unknown: manifest unknown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants