-
Notifications
You must be signed in to change notification settings - Fork 280
Nginx Root User and Port issue Fix: ProductivitySuite #1893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sgurunat
wants to merge
2
commits into
opea-project:main
Choose a base branch
from
sgurunat:opea-issue-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nginx harcoded port issue will be fixed. Removed env.sh in UI which needs root user, also used nginx-unprivileged image which uses non root user. Updated docker compose file and readme accordingly Signed-off-by: Gurunath S <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes issues related to running ProductivitySuite as root and port conflicts by updating the nginx configuration and routing setup.
- Updated docker compose file to include a new nginx service (productivity-suite-nginx-server) with relevant environment variables and dependency settings.
- Modified the README to reflect the new nginx routing and remove outdated environment variable definitions.
Reviewed Changes
Copilot reviewed 2 out of 7 changed files in this pull request and generated no comments.
File | Description |
---|---|
ProductivitySuite/docker_compose/intel/cpu/xeon/compose.yaml | Added a new nginx service configuration and updated environment variables for better service routing. |
ProductivitySuite/docker_compose/intel/cpu/xeon/README.md | Updated documentation to explain the new nginx routing and removed references to deprecated environment variables. |
Files not reviewed (5)
- ProductivitySuite/docker_compose/intel/cpu/xeon/set_env.sh: Language not supported
- ProductivitySuite/ui/docker/Dockerfile.react: Language not supported
- ProductivitySuite/ui/react/.env.production: Language not supported
- ProductivitySuite/ui/react/env.sh: Language not supported
- ProductivitySuite/ui/react/package.json: Language not supported
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Please fix the CI issue
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is related to below mentioned issues on root user and nginx port. I have updated GenAIComps nginx which is a dependency for this PR.
Have updated ProductivitySuite to use nginx server to route to different services. Updated relevant docker compose file and readme. Removed env.sh file which needed root user. For ProductivitySuite all the routings will happen via nginx server.
Issues
This change is related to below issues:
#517
#503
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
This PR depends on GenAIComps changes made for nginx. Dependency PR: opea-project/GenAIComps#1636
Tests
Tested all the features of ProductivitySuite