Skip to content

ChatQnA - Adding files to deploy an application in the K8S environment using Helm #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

chyundunovDatamonsters
Copy link
Contributor

Description

Adding files to deploy an application in the K8S environment using Helm

Issues

Type of change

List the type of change like below. Please delete options that are not relevant.

  • [*] New feature (non-breaking change which adds new functionality)

Dependencies

Tests

Copy link

github-actions bot commented Apr 5, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

@chensuyue chensuyue added this to the v1.4 milestone Apr 10, 2025
@chensuyue chensuyue mentioned this pull request Apr 10, 2025
4 tasks
@yinghu5 yinghu5 requested a review from yongfengdu April 24, 2025 01:29
Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor edits

### Cloning repos

```bash
git clone git clone https://github.com/opea-project/GenAIExamples.git
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
git clone git clone https://github.com/opea-project/GenAIExamples.git
git clone https://github.com/opea-project/GenAIExamples.git


#### If ROCm vLLM used
```bash
nano ~/chatqna-k8s-install/GenAIExamples/ChatQnA/kubernetes/helm/rocm-values.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could assume you are already in the correct directory, namely
~/chatqna-k8s-install/GenAIExamples/ChatQnA/kubernetes/helm


#### If deploy FaqGen based application on AMD ROCm device with vLLM
```bash
nano ~/chatqna-k8s-install/GenAIExamples/ChatQnA/kubernetes/helm/faqgen-rocm-values.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto, could assume you are in the correct directory

#### If ROCm TGI used

```bash
nano ~/chatqna-k8s-install/GenAIExamples/ChatQnA/kubernetes/helm/rocm-tgi-values.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto on directory


### Installing the Helm Chart

#### If ROCm vLLM used
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this heading not bold faced while others below are?

@yinghu5 yinghu5 requested a review from lianhao May 7, 2025 06:21
@yinghu5
Copy link
Collaborator

yinghu5 commented May 7, 2025

Hi @yongfengdu @lianhao
Could you please help to review the PR? thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants