Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Langchainvdms update #1303

Closed
wants to merge 13 commits into from
Closed

Conversation

cwlacewe
Copy link
Contributor

WIP - PENDING LANGCHAIN MERGE

Description

VDMS integration in LangChain recently updated. This PR adds the necessary changes prior to previous version being deprecated.

Issues

n/a

Type of change

  • [x ] Others (enhancement, documentation, validation, etc.) -> VDMS in Langchain-community will be deprecated

Dependencies

langchain-vdms

Tests

Ran provided tests without any errors:

cd tests
alias python=python3
bash dataprep/test_dataprep_vdms.sh
bash retrievers/test_retrievers_vdms.sh

cwlacewe and others added 5 commits February 20, 2025 22:57
Signed-off-by: Lacewell, Chaunte W <[email protected]>
…#1290)

* Fix telemetry connection issue when disabling telemetry

- use ENABLE_OPEA_TELEMETRY to control whether to enable open telemetry, default false
- fix the issue that logs always show telemetry connection error with each request when telemetry is disabled
- ban the above error propagation to microservices when telemetry is disabled

Signed-off-by: Spycsh <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix ut failure where required the flag to be on

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Spycsh <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
for more information, see https://pre-commit.ci

Signed-off-by: Lacewell, Chaunte W <[email protected]>
@cwlacewe cwlacewe force-pushed the langchainvdms_update branch from ceb8509 to c27de43 Compare February 21, 2025 06:58
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
comps/cores/mega/orchestrator.py 91.21% <100.00%> (+0.03%) ⬆️
comps/cores/telemetry/opea_telemetry.py 94.87% <100.00%> (-5.13%) ⬇️

... and 1 file with indirect coverage changes

cwlacewe and others added 8 commits February 20, 2025 23:03
…opea-project#1298)

* Refine CLI embedding microservice using dependency
Signed-off-by: lvliang-intel <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
1. set default session_id for react_langchain strategy, because the langchain version upgrade.
2. fix request message format

Signed-off-by: Lacewell, Chaunte W <[email protected]>
Signed-off-by: lvliang-intel <[email protected]>
Co-authored-by: Letong Han <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Liang Lv <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
* Refine dataprep Milvus CI
Signed-off-by: letonghan <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
…t#1292)

* Change neo4j Bolt default PORT from 7687 to

-configured the port in neo4j compose.yaml to use variable value
-made all corresponding changes in neo4j  dataprep and retriever components and test scripts to use env variable instead of default port value.

Signed-off-by: rbrugaro <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* missing positional arg in milvus dataprep

Signed-off-by: rbrugaro <[email protected]>

* remove redundance in stop_docker

Signed-off-by: rbrugaro <[email protected]>

* resolve retriever to neo4j connectivity issue bad URL

Signed-off-by: rbrugaro <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* set neo4j ports to neo4j defaults and fix environment variables in READMEs

Signed-off-by: rbrugaro <[email protected]>

---------

Signed-off-by: rbrugaro <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Liang Lv <[email protected]>
Signed-off-by: Lacewell, Chaunte W <[email protected]>
@cwlacewe cwlacewe closed this Feb 21, 2025
@cwlacewe cwlacewe deleted the langchainvdms_update branch February 21, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants