Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nebula #1265

Open
wants to merge 66 commits into
base: main
Choose a base branch
from
Open

Nebula #1265

wants to merge 66 commits into from

Conversation

jeanyu-habana
Copy link

Description

support NebulaGraph cluster deployment in k8s

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

n/a

Tests

Tested the deployment and config scripts. NebulaGraph services were up and running. DB spaces can be created and managed.

jeanyu-habana and others added 8 commits February 7, 2025 15:23
@jeanyu-habana
Copy link
Author

jeanyu-habana commented Feb 14, 2025

Hi @jeanyu-habana , Please check the failed Online Document Building CI. Also, please add a test script for your third-party component here, following the naming schema. Thanks!

Added component test script and fixed document building CI error. Please review.

Do you know if there is a document with information on the target k8s cluster? For example, storageClass, namespace, etc. Also, what's the general process for adding docker images for our services to OPEA's docker hub: https://hub.docker.com/u/opea? These questions are for my future PRs. Thanks! @letonghan

Signed-off-by: jeanyu-habana <[email protected]>
Signed-off-by: jeanyu-habana <[email protected]>
Signed-off-by: jeanyu-habana <[email protected]>
Signed-off-by: jeanyu-habana <[email protected]>
Signed-off-by: jeanyu-habana <[email protected]>
Signed-off-by: jeanyu-habana <[email protected]>
Signed-off-by: jeanyu-habana <[email protected]>
Signed-off-by: jeanyu-habana <[email protected]>
@chensuyue
Copy link
Collaborator

Hi @jeanyu-habana , Please check the failed Online Document Building CI. Also, please add a test script for your third-party component here, following the naming schema. Thanks!

Added component test script and fixed document building CI error. Please review.

Do you know if there is a document with information on the target k8s cluster? For example, storageClass, namespace, etc. Also, what's the general process for adding docker images for our services to OPEA's docker hub: https://hub.docker.com/u/opea? These questions are for my future PRs. Thanks! @letonghan

If you want to release a new image into docker hub, add the image information here, and it will be released on docker hub in the latest release schedule. The latest future release version is v1.3, which will be released on 4/25.

@chensuyue
Copy link
Collaborator

Hi @jeanyu-habana , Please check the failed Online Document Building CI. Also, please add a test script for your third-party component here, following the naming schema. Thanks!

Added component test script and fixed document building CI error. Please review.

Do you know if there is a document with information on the target k8s cluster? For example, storageClass, namespace, etc. Also, what's the general process for adding docker images for our services to OPEA's docker hub: https://hub.docker.com/u/opea? These questions are for my future PRs. Thanks! @letonghan

For k8s deployment, refer to comps/xxx/deployment/kubernetes/README.md, like this one, https://github.com/opea-project/GenAIComps/blob/main/comps/asr/deployment/kubernetes/README.md. The template itself is in https://github.com/opea-project/GenAIInfra/tree/main/helm-charts/common. When you add a new values in GenAIComps and the template is available in Github Package, then the CI will be triggered automatically on our k8s cluster.

@jeanyu-habana
Copy link
Author

Hi @jeanyu-habana , Please check the failed Online Document Building CI. Also, please add a test script for your third-party component here, following the naming schema. Thanks!

Added component test script and fixed document building CI error. Please review.

Do you know if there is a document with information on the target k8s cluster? For example, storageClass, namespace, etc. Also, what's the general process for adding docker images for our services to OPEA's docker hub: https://hub.docker.com/u/opea? These questions are for my future PRs. Thanks! @letonghan

Would you be able to review the changes sometime soon? Any additional comments before the issues can be resolved? Would love to see the PR merged soon. Please let me know. Thanks! @letonghan

@jeanyu-habana
Copy link
Author

Hi @jeanyu-habana , Please check the failed Online Document Building CI. Also, please add a test script for your third-party component here, following the naming schema. Thanks!

Added component test script and fixed document building CI error. Please review.
Do you know if there is a document with information on the target k8s cluster? For example, storageClass, namespace, etc. Also, what's the general process for adding docker images for our services to OPEA's docker hub: https://hub.docker.com/u/opea? These questions are for my future PRs. Thanks! @letonghan

For k8s deployment, refer to comps/xxx/deployment/kubernetes/README.md, like this one, https://github.com/opea-project/GenAIComps/blob/main/comps/asr/deployment/kubernetes/README.md. The template itself is in https://github.com/opea-project/GenAIInfra/tree/main/helm-charts/common. When you add a new values in GenAIComps and the template is available in Github Package, then the CI will be triggered automatically on our k8s cluster.

Thank you for your prompt responses. I appreciate the help. @chensuyue

Copy link
Collaborator

@letonghan letonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants