adding reconcilers for a service account #51
Conversation
… to create role/rolebinding/serviceaccount to controller, added service account to the deployment, and fixed syntax errors on the role and rolebinding reconsilers
exe-prow-github-app
bot
added
the
do-not-merge/work-in-progress
exe-prow-github-app
bot
added
the
approved
|
I seem to be having an issue with the permissions to create the role and role binding, but I'm not sure what's causing it at the moment |
There was a problem hiding this comment.
This is a great start, as mentioned when we spoke the RBACs don't need to be edited manually just update the below marker in the controller filed to include serviceaccount
// +kubebuilder:rbac:groups=core,resources=pods;services;serviceaccounts,verbs=update;create;get;list;watch
After that run make manifests and the files needed to be checked in will be generated.
…r go style, and added rbac changes to the rbac generation code
exe-prow-github-app
bot
removed
the
do-not-merge/work-in-progress
Co-authored-by: Adam Cornett <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, dhoover103 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a fix for issue #15
adds new reconcilers for a service account, role, and role binding