cli: add support for passing proxy command line parameter #981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's sometimes usefult to have rules for building for "this system" (i.e., the current GOOS/GOARCH) for testing the binary locally or remotely. Rather than requiring developers to remember the correct way to include the psiphon config and strip binaries, let's have a rule for that.
bassosimone
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the bare minimum needed to have circumvention proxy support in OONI Probe CLI.
The reference issue is ooni/probe#1955. (Most of that issue is implemented, save for the fact that currently we do not have support for
httpandhttpsproxies.)While there, add to
Makefilea rule for correctly buildingooniprobeandminioonifor "this system" (i.e., the defaultGOOSandGOARCHon a system), because we needed this for testing this patch and we needed to figure out the commands instead.