catch uncaught BaseException and asyncio.CancelledError - #1231
Open
aagbsn wants to merge 4 commits into
Open
Conversation
because asyncio.CancelledError inherits from BaseException rather than Exception it may not be caught, and FastAPI may not log these exceptions in the same way.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1231 +/- ##
==========================================
- Coverage 92.42% 92.19% -0.24%
==========================================
Files 86 86
Lines 8599 8624 +25
Branches 509 509
==========================================
+ Hits 7948 7951 +3
- Misses 541 563 +22
Partials 110 110
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ncellederror_baseexception
I noticed we do catch BaseException raised by check_ooniauth_health, but not _verify_submit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because asyncio.CancelledError inherits from BaseException rather than Exception it may not be caught, and FastAPI may not log these exceptions in the same way.