Add ParksOverlay example profile with MapLibre style#1514
Open
permission-error1 wants to merge 3 commits intoonthegomap:mainfrom
Open
Add ParksOverlay example profile with MapLibre style#1514permission-error1 wants to merge 3 commits intoonthegomap:mainfrom
permission-error1 wants to merge 3 commits intoonthegomap:mainfrom
Conversation
Full logs: https://github.com/onthegomap/planetiler/actions/runs/23128446480 |
|
Author
|
@msbarry, Can I add the For SonarCloud analysis fail, the duplication warning is from boilerplate that all the other examples share too (imports, attribution, run/main). Not sure how to reduce it without making the code inconsistent with the rest of the examples. |
msbarry
reviewed
Mar 16, 2026
Contributor
msbarry
left a comment
msbarry
left a comment
There was a problem hiding this comment.
Minor comments but otherwise looks great, thanks!
Comment on lines
+28
to
+30
|
|
||
| parks-map.html | ||
| parks-style.json No newline at end of file |
Contributor
There was a problem hiding this comment.
Can we revert these 2 lilnes? I usually put temp files like this in data/ directory
| assertEquals("Parks Overlay", metadata.get("name")); | ||
| assertContains("openstreetmap.org/copyright", metadata.get("attribution")); | ||
|
|
||
| TestUtils.assertTileDuplicates(mbtiles, 0); |
Contributor
There was a problem hiding this comment.
Could you add one call to TestUtils.assertNumFeatures here to verify the output actually contains a park polygon?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a small Planetiler example profile that extracts
parks and gardens from OpenStreetMap using the tags:
leisure=park
leisure=garden
The example includes:
Screenshot:
