chore(dep): Remove the ordered_float crate, because after v4.0 it wil…#10
Merged
AdilZouitine merged 1 commit intoonline-ml:masterfrom Jul 31, 2025
Merged
Conversation
…l need the FloatCore trait to use the NotNan trait, which will cause conflict with num::Float. Since we are only using NotNan from ordered_float, we can simply manually cause panic when the value is nan.
AdilZouitine
approved these changes
Jul 31, 2025
Member
AdilZouitine
left a comment
AdilZouitine
left a comment
There was a problem hiding this comment.
LGTM thank you for your contribution 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the ordered_float crate, because after v4.0 it will need the FloatCore trait to use the NotNan trait, which will cause conflict with num::Float. Since we are only using NotNan from ordered_float, we can simply manually cause panic when the value is nan.