Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unity 5 Support #48

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Unity 5 Support #48

wants to merge 7 commits into from

Conversation

quasmon
Copy link

@quasmon quasmon commented Mar 26, 2015

Hey there,

I ran into a few issues while getting our projects working with Unity 5 and wanted to share the fixes as some people might find them helpful:

  • When an Xcode project was loaded by Unity (during an append) we would see an exception being thrown because the path values that contained "-" for some file references were not quote escaped.
  • Unity seems to add file references with no build phase which meant when adding a projmod addition for e.g. AdSupport.framework it was ignored. Had to make some changes to allow phase changes and also detecting duplicate build files being added.

Feel free to let me know if you need anything changed.

Cheers,
Ramon.

quasmon added 7 commits March 26, 2015 22:21
Unity 5 expects string values that contain "-" characters to be quote escaped like Xcode does
Previously file references that already existed but had a build phase set would be ignored. Unity 5 generates file references e.g AdSupport.framework that don't belong to any build phase. Change the way file references are added so that a change to a build phase will add that file to the required build phase. Required changing the build references to not allow duplicates
Was throwing an exception because it already exists
applied correctly. Also move compiler flags from file references to
build files since thats where they are saved
Still support Unity 4.x though
Don’t need it printing out for other platforms
@onevcat
Copy link
Owner

onevcat commented Jun 20, 2015

Hi, @quasmon

Sorry for the late reply.

Thanks for the p-r, it looks great to me.

Unity 5 has its own dependency system to add frameworks and third party files easier than Unity 4. So the priority to support Unity 5 is not so high currently. But I will take a look at it and try to resolve the conflict and merge it later.

@Brantone
Copy link

I like that 555b2a4 solves #38 ... how hard would it be to update that for folders as well?

Also, although Unity 5 has incorporated some libraries, it's still not as ease to use like projmods for things like lproj folders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants