[CTL] Add disjoint pool allocation balance counter #1334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KFilipek
force-pushed
the
ctl-disjoint_counters
branch
from
6c4e59a to
ba5c390
Compare
ldorau
reviewed
May 28, 2025
src/pool/pool_disjoint.c
Outdated
| static const umf_ctl_node_t CTL_NODE(disjoint)[] = {CTL_LEAF_RW(name), | ||
| CTL_NODE_END}; | ||
| // CTL: allocation counters | ||
| atomic_int counter_alloc_balance; |
There was a problem hiding this comment.
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.43.34808\include\vcruntime_c11_stdatomic.h(16,1): error C1189: #error: "C atomics require C11 or later" [D:\a\unified-memory-framework\unified-memory-framework\build\src\umf.vcxproj]
(compiling source file '../../src/pool/pool_disjoint.c')
There was a problem hiding this comment.
I think you should use our utils from utils_concurrency.h.
KFilipek
force-pushed
the
ctl-disjoint_counters
branch
from
ba5c390 to
3bf6fd7
Compare
bratpiorka
reviewed
May 28, 2025
src/pool/pool_disjoint.c
Outdated
| @@ -745,7 +761,7 @@ umf_result_t disjoint_pool_initialize(umf_memory_provider_handle_t provider, | |||
| void *disjoint_pool_malloc(void *pool, size_t size) { | |||
| disjoint_pool_t *hPool = (disjoint_pool_t *)pool; | |||
| void *ptr = disjoint_pool_allocate(hPool, size); | |||
|
|
|||
| atomic_fetch_add(&counter_alloc_balance, 1); | |||
There was a problem hiding this comment.
use utils_atomic_increment_u64
KFilipek
force-pushed
the
ctl-disjoint_counters
branch
from
3bf6fd7 to
9dce66e
Compare
KFilipek
force-pushed
the
ctl-disjoint_counters
branch
from
9dce66e to
0609557
Compare
pbalcer
reviewed
Jun 6, 2025
src/pool/pool_disjoint.c
Outdated
| static const umf_ctl_node_t CTL_NODE(disjoint)[] = {CTL_LEAF_RW(name), | ||
| CTL_NODE_END}; | ||
| // CTL: allocation counters | ||
| uint64_t allocation_balance = 0; |
| @@ -33,6 +33,7 @@ static char *DEFAULT_NAME = "disjoint"; | |||
| struct ctl disjoint_ctl_root; | |||
| static UTIL_ONCE_FLAG ctl_initialized = UTIL_ONCE_FLAG_INIT; | |||
|
|
|||
| // CTL: name attribute | |||
There was a problem hiding this comment.
isn't this something we could implement generically for any pool implementation in the umfPoolAlloc/umfPoolFree interface?
| // CTL: allocation counters | ||
| uint64_t allocation_balance = 0; | ||
|
|
||
| static int CTL_READ_HANDLER(allocation_balance)( |
There was a problem hiding this comment.
we should have docs that list all ctl interfaces.
There was a problem hiding this comment.
I will prepare the docs after this PR, which we discussed previously (with @lplewa @bratpiorka).
KFilipek
force-pushed
the
ctl-disjoint_counters
branch
5 times, most recently
from
cef102e to
d30e9f9
Compare
KFilipek
force-pushed
the
ctl-disjoint_counters
branch
from
d30e9f9 to
2c7329a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist