-
Notifications
You must be signed in to change notification settings - Fork 35
Add tests for tracking provider #1144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
a531874
to
4f91abe
Compare
PatKamin
reviewed
Feb 28, 2025
test/provider_tracking.cpp
Outdated
#define TEST_LEVEL_SUCCESS 7 | ||
#define TEST_LEVEL_FAILURE 8 | ||
|
||
TEST_P(TrackingProviderTest, success_max__levels) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: success_max_levels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Multilevel maps are needed to support the case when one memory pool acts as a memory provider for another memory pool (nested memory pooling). Signed-off-by: Lukasz Dorau <[email protected]>
4f91abe
to
4830048
Compare
Signed-off-by: Lukasz Dorau <[email protected]>
Signed-off-by: Lukasz Dorau <[email protected]>
Signed-off-by: Lukasz Dorau <[email protected]>
9bfe7b7
to
7051bb2
Compare
Error out in case of double free() instead of assert in coarse library. Signed-off-by: Lukasz Dorau <[email protected]>
7051bb2
to
bf97c44
Compare
Signed-off-by: Lukasz Dorau <[email protected]>
bf97c44
to
e75b939
Compare
Incorporated into #1143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tests for tracking provider.
Checklist