Conversation
ea23f58 to
d17e24c
Compare
Contributor
Author
|
Currently, the diff itself is not rendered. I wonder if that is due to AsciiDoc or due to the file size. When I switch between
|
|
Maybe GitHub has changed, but I'm able to see both source and rich diffs (which I didn't even know existed until you mentioned them!). I agree it's a great improvement for basic changes, but have the following reservations:
However I think use of diffs should cope with 90% of the issues (rough guess) and we could think of conventions for representing the remainder of the changes to supplement the diffs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an example pull request that illustrates how the changes of the following issue would be expressed in Git: https://issues.omg.org/browse/DMN15-44
Reviewing this change as a diff is far superior that reading the editing instructions in JIRA.
Rendering before: https://github.com/omg-dmn-taskforce/plain-text-spec/blob/main/10-expression-language-FEEL.adoc#type-conversions
Rendering after: https://github.com/omg-dmn-taskforce/plain-text-spec/blob/DMN15-44/10-expression-language-FEEL.adoc#type-conversions