Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/hard link #17

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

Daniel-KM
Copy link
Contributor

To hard link files is quicker, safe, and space efficient. So this pull request add an option to enable it.

This pr is based on previous ones, but i can separate it if needed.

@Daniel-KM Daniel-KM requested a review from jimsafley January 24, 2020 09:15
@Daniel-KM Daniel-KM force-pushed the feature/hard_link branch 2 times, most recently from 67a0b8e to 3d597c1 Compare February 3, 2020 09:19
@Daniel-KM
Copy link
Contributor Author

Rebased.

@jimsafley
Copy link
Contributor

I don't fully know what problem this is solving, but it seems to have a narrow use case, so I'm unconvinced of it's value to our general audience. Given the amount of code this introduces, we have to weigh the feature's value with the amount of work it will take to maintain into the long term.

@Daniel-KM Daniel-KM force-pushed the feature/hard_link branch 2 times, most recently from 9da32e7 to cc76907 Compare June 1, 2020 15:10
@Daniel-KM
Copy link
Contributor Author

This is for people who have a small hard drive. It increases performance too, since temp is done on the same hard drive than other files. But this is not so frequent nowadays.

@jimsafley
Copy link
Contributor

Thanks for the clarification. I'm going to let this one sit until we have a sense that it has broader appeal from our users. To my knowledge, no one has expressed need for this, and I hesitate to merge a feature (especially one that requires a specific configuration on the server) without gauging our users' needs.

@Daniel-KM Daniel-KM force-pushed the feature/hard_link branch 2 times, most recently from 13dfa29 to 3398094 Compare October 29, 2022 06:12
@allanaaa allanaaa mentioned this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants