Fix event loop blocking in async RequestExecutor (Fixes #89) #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace time.sleep() with asyncio.sleep() in rate limiting loop - Replace sync retry_call() with async-compatible retry loop - Remove retry2 dependency (incompatible with async functions) - Remove unused requests dependency
eduards-vavere
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
time.sleep()in the rate limiting loopretry2not supporting async functionsretry2andrequestsdependencies (unused/incompatible)Related Issues
Fixes #89
Problem
The
RequestExecutor.get()method had two issues causing problems in async environments (e.g., FastAPI):time.sleep(0.1)blocked the entire event loop during rate limitingretry_call()fromretry2returns a coroutine without awaiting it, causing retries to silently failSolution
Minimal fix replacing both with native asyncio equivalents:
time.sleep(0.1)→await asyncio.sleep(0.1)retry_call()→ simple async for-loop with exponential backoffTest plan
pytest tests/unit)