Skip to content

Conversation

@ivanezeigbo-okta
Copy link

Summary

Adding cucumber feature tests for password optional and login identifier first among other .NET cucumber scenarios to be covered. This is the first batch of tests from password optional.

Type of PR

  • Bug Fix (non-breaking fixes to existing functionality)
  • New Feature (non-breaking changes that add new functionality)
  • Documentation update
  • Test Updates
  • Other (Please describe the type)

Test Information

  • My PR required test updates

.NET Version:
Os Version:

Signoff

  • I have submitted a CLA for this PR
  • Each commit message explains what the commit does
  • I have updated documentation to explain what my PR does
  • My code is covered by tests if required
  • I checked StyleCop warnings on my code

Copy link
Contributor

@bryanapellanes-okta bryanapellanes-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this work still in progress?

{
var options = new ChromeOptions();
options.AddArgument("--headless");
//options.AddArgument("--headless");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncomment this; the builds should run headless.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, missed that! :) Thanks

And a user named "Mary"
And Mary does not have an account in the org

@ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason that this is ignored?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, ignored those because email passcode comes in twice so sometimes the test fails if it picks the first code and not the second. I believe we prob had this conversation before about that limitation.

And the cell for the value of name is shown and contains her first name and last name
And the preferred_username claim is shown and matches Mary's email

@ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as previous, is this ignored for a reason?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, see above comment. If you run it locally however and put a wait before entering the passcode, it should pass fine.

Copy link
Contributor

@laura-rodriguez laura-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivanezeigbo-okta , can you please include a quick recording showing how the e2e works? We usually do that to help reviewers to understand the PR better. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants