-
Notifications
You must be signed in to change notification settings - Fork 21
Adding tests for password optional and identifier first login #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
bryanapellanes-okta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this work still in progress?
| { | ||
| var options = new ChromeOptions(); | ||
| options.AddArgument("--headless"); | ||
| //options.AddArgument("--headless"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uncomment this; the builds should run headless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, missed that! :) Thanks
| And a user named "Mary" | ||
| And Mary does not have an account in the org | ||
|
|
||
| @ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason that this is ignored?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, ignored those because email passcode comes in twice so sometimes the test fails if it picks the first code and not the second. I believe we prob had this conversation before about that limitation.
| And the cell for the value of name is shown and contains her first name and last name | ||
| And the preferred_username claim is shown and matches Mary's email | ||
|
|
||
| @ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as previous, is this ignored for a reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, see above comment. If you run it locally however and put a wait before entering the passcode, it should pass fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivanezeigbo-okta , can you please include a quick recording showing how the e2e works? We usually do that to help reviewers to understand the PR better. Thank you!
Summary
Adding cucumber feature tests for password optional and login identifier first among other .NET cucumber scenarios to be covered. This is the first batch of tests from password optional.
Type of PR
Test Information
.NET Version:
Os Version:
Signoff