OKTA-439188 [.NET IDX SDK] - Implement Scenario 10.1 (TOTP) #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IDX package part
andriizhegurov-okta
requested review from
bryanapellanes-okta and
laura-rodriguez
Contributor
bryanapellanes-okta
left a comment
bryanapellanes-okta
left a comment
There was a problem hiding this comment.
A minor comment. Also, there appear to be test failures; are there tests that can be added to validate/support this change?
Contributor
laura-rodriguez
left a comment
laura-rodriguez
left a comment
There was a problem hiding this comment.
The implementation looks good to me, but I suggest adding UTs to cover the new feature.
bryanapellanes-okta
changed the base branch from
master
to
integration-vNext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDX package part