Handle deleted articles - #378
Open
pedrogaudencio wants to merge 5 commits into
Open
Conversation
* articleCommitLink replaces the invalid /article/{owner}/{subject}/commit/{sha} path in both commit markup processors
* Repository.CommitLink uses ?version= for article URLs and keeps /commit/{sha} for permanent repository URLs (archived articles)
* adds TestArticleCommitLink integration coverage plus unit tests; updates affected renderhelper/markdown expectations
* UpdateIssuesCommit no longer concatenates /commit/{sha} onto the article vanity URL, which had no matching route
* adds TestUpdateIssuesCommitRefCommentLink covering article, special-character subject, and archived-article cases
* trade-off: only new ref comments are fixed; existing stored comment HTML would need a migration
* preserve git data and fork ancestry instead of hard-deleting when forks exist; block web, API, and git transport access. * add tombstone placeholder page, table badge, delete-modal warning, and locale strings.
* skip the versioned article URL in CommitLink when the repository is archived, so commit references resolve to /{owner}/{repo}/commit/{sha}.
* guard placed before Link() so GetSubject is not invoked on the archived path.
github-actions
Bot
added
modifies/templates
modifies/go
modifies/migrations
modifies/api
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an article is deleted, we should follow a “tombstone UX”, particularly when the deleted article has forks:
Closes #62
AI Disclosure
Co-authored with: Opus 5